Differential D8515

[protocol] Remove unused CADDR_TIME_VERSION
ClosedPublic
Actions

Authored by Fabien on Nov 24 2020, 13:16.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC678e25812f4d: [protocol] Remove unused CADDR_TIME_VERSION

Summary

These constants are no longer required and can be removed.

Additional code comments are added to explain CAddress serialization.

Backport of core PR19486.

Depends on D8514.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 24 2020, 13:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 13:16

Fabien requested review of this revision.Nov 24 2020, 13:16

teamcity edited the summary of this revision. (Show Details)Nov 24 2020, 13:16

Harbormaster completed remote builds in B14188: Diff 26002.Nov 24 2020, 13:17

deadalnix accepted this revision.Nov 24 2020, 13:20

This revision is now accepted and ready to land.Nov 24 2020, 13:20

Closed by commit rABC678e25812f4d: [protocol] Remove unused CADDR_TIME_VERSION (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyNov 24 2020, 13:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC678e25812f4d: [protocol] Remove unused CADDR_TIME_VERSION.

Revision Contents
Changeset List

Path

Size

src/

protocol.h

17 lines

version.h

9 lines

test/

functional/

test_framework/

messages.py

14 lines

Diff 26006

View Options

src/protocol.h

View Options

src/version.h

View Options

test/functional/test_framework/messages.py

[protocol] Remove unused CADDR_TIME_VERSIONClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26006

src/protocol.h

src/version.h

test/functional/test_framework/messages.py

[protocol] Remove unused CADDR_TIME_VERSION
ClosedPublic
Actions

Revision Contents
Changeset List