Differential D8514

Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater
ClosedPublic
Actions

Authored by Fabien on Nov 24 2020, 12:59.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCb3acb54e6ca1: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater

Summary

After the version handshake, the version must be >=
MIN_PEER_PROTO_VERSION, since we immediately disconnect any peer that
advertises a lower version than that in its version message

Backport of core PR14033.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 24 2020, 12:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 13:00

Fabien requested review of this revision.Nov 24 2020, 13:00

teamcity edited the summary of this revision. (Show Details)Nov 24 2020, 13:00

Harbormaster completed remote builds in B14187: Diff 26001.Nov 24 2020, 13:01

deadalnix accepted this revision.Nov 24 2020, 13:01

This revision is now accepted and ready to land.Nov 24 2020, 13:01

Fabien added a child revision: D8515: [protocol] Remove unused CADDR_TIME_VERSION.Nov 24 2020, 13:16

Closed by commit rABCb3acb54e6ca1: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyNov 24 2020, 13:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb3acb54e6ca1: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater.

Revision Contents
Changeset List

Path

Size

src/

net.h

1 line

net.cpp

4 lines

net_processing.cpp

17 lines

Diff 26005

View Options

src/net.h

View Options

src/net.cpp

View Options

Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greaterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26005

src/net.h

src/net.cpp

src/net_processing.cpp

Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater
ClosedPublic
Actions

Revision Contents
Changeset List