Differential D8564

validation: Make ProcessNewBlock*() members of ChainstateManager
ClosedPublic
Actions

Authored by Fabien on Dec 1 2020, 08:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCc2fa271b7284: validation: Make ProcessNewBlock*() members of ChainstateManager

Summary

Partial backport (5/6) of core PR18698:
https://github.com/bitcoin/bitcoin/pull/18698/commits/fa1d97b25686a5caca623599f6d608fd08616fe8

Depends on D8563.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18698_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14255
Build 28489: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 28488: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 1 2020, 08:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2020, 08:58

Fabien requested review of this revision.Dec 1 2020, 08:58

teamcity edited the summary of this revision. (Show Details)Dec 1 2020, 08:58

Harbormaster completed remote builds in B14255: Diff 26109.Dec 1 2020, 09:13

Fabien added a child revision: D8565: validation: Mark g_chainman DEPRECATED.Dec 1 2020, 09:42

deadalnix accepted this revision.Dec 1 2020, 15:10

This revision is now accepted and ready to land.Dec 1 2020, 15:10

Closed by commit rABCc2fa271b7284: validation: Make ProcessNewBlock*() members of ChainstateManager (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 1 2020, 16:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc2fa271b7284: validation: Make ProcessNewBlock*() members of ChainstateManager.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

21 lines

rpc/

blockchain.h

2 lines

blockchain.cpp

5 lines

mining.cpp

32 lines

test/

blockfilter_index_tests.cpp

12 lines

checkpoints_tests.cpp

16 lines

miner_tests.cpp

3 lines

util/

mining.cpp

3 lines

setup_common.cpp

3 lines

validation_block_tests.cpp

22 lines

validation.h

94 lines

validation.cpp

18 lines

Diff 26109

View Options

src/net_processing.cpp

View Options

src/rpc/blockchain.h

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/checkpoints_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/util/mining.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/validation.h

View Options

validation: Make ProcessNewBlock*() members of ChainstateManagerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26109

src/net_processing.cpp

src/rpc/blockchain.h

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/checkpoints_tests.cpp

src/test/miner_tests.cpp

src/test/util/mining.cpp

src/test/util/setup_common.cpp

src/test/validation_block_tests.cpp

src/validation.h

src/validation.cpp

validation: Make ProcessNewBlock*() members of ChainstateManager
ClosedPublic
Actions

Revision Contents
Changeset List