The banscore are more granular this way and can be tuned on a per error basis.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABCbf4044fdd64d: [avalanche] Use more sensible banscores
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Tail of the build log:
/work /work/abc-ci-builds/lint-circular-dependencies A new circular dependency in the form of "avalanche/processor -> net_processing -> avalanche/processor" appears to have been introduced. /work/abc-ci-builds/lint-circular-dependencies Build lint-circular-dependencies failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
[360/418] bitcoin: testing torcontrol_tests [361/418] Running utility command for check-bitcoin-sync_tests [362/418] Running utility command for check-bitcoin-wallet_crypto_tests [363/418] bitcoin: testing settings_tests [364/418] Running utility command for check-bitcoin-torcontrol_tests [365/418] bitcoin: testing timedata_tests [366/418] Running utility command for check-bitcoin-settings_tests [367/418] Running utility command for check-bitcoin-timedata_tests [368/418] bitcoin: testing streams_tests [369/418] bitcoin: testing undo_tests [370/418] Running utility command for check-bitcoin-streams_tests [371/418] Running utility command for check-bitcoin-undo_tests [372/418] bitcoin: testing util_threadnames_tests [373/418] Running utility command for check-bitcoin-util_threadnames_tests [374/418] bitcoin: testing validation_chainstatemanager_tests [375/418] bitcoin: testing compilerbug_tests [376/418] Running utility command for check-bitcoin-validation_chainstatemanager_tests [377/418] Running utility command for check-bitcoin-compilerbug_tests [378/418] bitcoin: testing checkpoints_tests [379/418] bitcoin: testing txvalidationcache_tests [380/418] Running utility command for check-bitcoin-checkpoints_tests [381/418] Running utility command for check-bitcoin-txvalidationcache_tests [382/418] bitcoin: testing validationinterface_tests [383/418] Running utility command for check-bitcoin-validationinterface_tests [384/418] bitcoin: testing cashaddr_tests [385/418] Running utility command for check-bitcoin-cashaddr_tests [386/418] bitcoin: testing getarg_tests [387/418] bitcoin: testing radix_tests [388/418] Running utility command for check-bitcoin-getarg_tests [389/418] bitcoin: testing blockcheck_tests [390/418] Running utility command for check-bitcoin-radix_tests [391/418] Running utility command for check-bitcoin-blockcheck_tests [392/418] bitcoin: testing crypto_tests [393/418] Running utility command for check-bitcoin-crypto_tests [394/418] bitcoin: testing ref_tests [395/418] Running utility command for check-bitcoin-ref_tests [396/418] bitcoin: testing cuckoocache_tests [397/418] bitcoin: testing script_tests [398/418] Running utility command for check-bitcoin-cuckoocache_tests [399/418] Running utility command for check-bitcoin-script_tests [400/418] bitcoin: testing validation_tests [401/418] Running utility command for check-bitcoin-validation_tests [402/418] bitcoin: testing monolith_opcodes_tests [403/418] Running utility command for check-bitcoin-monolith_opcodes_tests [404/418] bitcoin: testing skiplist_tests [405/418] Running utility command for check-bitcoin-skiplist_tests [406/418] bitcoin: testing coinselector_tests [407/418] Running utility command for check-bitcoin-coinselector_tests [408/418] bitcoin: testing util_tests [409/418] Running utility command for check-bitcoin-util_tests [410/418] bitcoin: testing op_reversebytes_tests [411/418] Running utility command for check-bitcoin-op_reversebytes_tests [412/418] bitcoin: testing transaction_tests [413/418] Running utility command for check-bitcoin-transaction_tests [414/418] bitcoin: testing coins_tests [415/418] Running utility command for check-bitcoin-coins_tests [416/418] Running bitcoin test suite PASSED: bitcoin test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1
Comment Actions
Add circular dependency.
It looks like this things doesn't differenciate header and cpp files, which is likely wrong.