Differential D8593

Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover
ClosedPublic
Actions

Authored by Fabien on Dec 3 2020, 16:11.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCe4b696038a82: Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover

Summary

Partial backport (6/11) of core PR18918:
https://github.com/bitcoin/bitcoin/pull/18918/commits/ced95d0e43389fe62b5d30fcc7c42dbca0e88242

Depends on D8592.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18918_p6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14291
Build 28557: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28556: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 3 2020, 16:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 16:11

Fabien requested review of this revision.Dec 3 2020, 16:11

teamcity edited the summary of this revision. (Show Details)Dec 3 2020, 16:11

Fabien added a child revision: D8594: Expose a version of ReadKeyValue and use it in RecoverKeysOnlyFilter.Dec 3 2020, 16:12

Harbormaster completed remote builds in B14291: Diff 26171.Dec 3 2020, 16:46

majcosta accepted this revision.Dec 3 2020, 18:58

This revision is now accepted and ready to land.Dec 3 2020, 18:58

Closed by commit rABCe4b696038a82: Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyDec 7 2020, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe4b696038a82: Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover.

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.h

10 lines

db.cpp

143 lines

Diff 26171

View Options

src/wallet/db.h