Differential D8595

Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone
ClosedPublic
Actions

Authored by Fabien on Dec 3 2020, 16:13.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC61875704dabb: Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone

Summary

Instead of having these be class static functions, just make them be
standalone. Also removes WalletBatch::Recover which just passed through
to BerkeleyBatch::Recover.

Partial backport (8/11) of core PR18918:
https://github.com/bitcoin/bitcoin/pull/18918/commits/b426c7764d26e280e1f814cf36e050743c45cd12

Depends on D8594.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18918_p8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14293
Build 28561: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28560: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 3 2020, 16:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 16:13

Fabien requested review of this revision.Dec 3 2020, 16:13

teamcity edited the summary of this revision. (Show Details)Dec 3 2020, 16:13

Fabien added a child revision: D8596: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}.Dec 3 2020, 16:14

Harbormaster completed remote builds in B14293: Diff 26173.Dec 3 2020, 16:55

Fabien edited the test plan for this revision. (Show Details)Dec 3 2020, 19:23

majcosta accepted this revision.Dec 3 2020, 19:25

This revision is now accepted and ready to land.Dec 3 2020, 19:25

Closed by commit rABC61875704dabb: Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyDec 7 2020, 08:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC61875704dabb: Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone.

Revision Contents
Changeset List

Path

Size

src/

wallet/

11 lines

10 lines

20 lines

26 lines

5 lines

Diff 26173

src/wallet/db.h

Loading...

src/wallet/db.cpp

Loading...

src/wallet/walletdb.h

Loading...

src/wallet/walletdb.cpp

Loading...

src/wallet/wallettool.cpp

Loading...