Page MenuHomePhabricator
Differential D8599

Add a way to verify schnorr signatures from an array.
ClosedPublic
Actions

Authored by deadalnix on Dec 3 2020, 22:38.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC9e1b95bf8e46: Add a way to verify schnorr signatures from an array.
Summary

This is a much better API.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 3 2020, 22:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 22:38
deadalnix requested review of this revision.Dec 3 2020, 22:38
Harbormaster completed remote builds in B14299: Diff 26180.Dec 3 2020, 22:49
deadalnix added a child revision: D8602: [avalanche] Add a mechanism to delegate proofs.Dec 4 2020, 01:08
majcosta requested changes to this revision.Dec 4 2020, 11:47
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/avalanche/processor.cpp
215 ↗(On Diff #26180)

can this magic number be replaced with CPubKey::SCHNORR_SIZE as well or can sig be something other than a Schnorr sig?

src/avalanche/proofbuilder.cpp
14 ↗(On Diff #26180)

ditto

src/net_processing.cpp
3871 ↗(On Diff #26180)

ditto

This revision now requires changes to proceed.Dec 4 2020, 11:47
deadalnix requested review of this revision.Dec 4 2020, 15:21

I don't see any reason to block this PR due to existing code that could be better.

majcosta accepted this revision.Dec 4 2020, 16:01

fair enough

This revision is now accepted and ready to land.Dec 4 2020, 16:01
Closed by commit rABC9e1b95bf8e46: Add a way to verify schnorr signatures from an array. (authored by deadalnix). · Explain WhyDec 4 2020, 16:31
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC9e1b95bf8e46: Add a way to verify schnorr signatures from an array..

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
4 lines
7 lines
3 lines
25 lines
5 lines
5 lines
22 lines

Diff 26193

View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/proof.cpp

Loading...
View Options

src/avalanche/proofbuilder.cpp

Loading...
View Options

src/key.h

Loading...
View Options

src/key.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/pubkey.cpp

Loading...