Page MenuHomePhabricator

Replace nHashType with SigHashType in rawtransaction.cpp
ClosedPublic

Authored by jasonbcox on Jan 2 2018, 00:05.

Details

Summary

Continue work replacing nHashType with SigHashType (see T61). Depends on D860.

Test Plan

Existing tests pass, which do hit this branch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rawtrans
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1476
Build 1476: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 2 2018, 00:05
deadalnix requested changes to this revision.Jan 2 2018, 00:56
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1032
sigHashType.getBaseSigHashType() != BaseSigHashType::SINGLE
This revision now requires changes to proceed.Jan 2 2018, 00:56

Fixed if statement negation

This revision is now accepted and ready to land.Jan 3 2018, 12:59
This revision was automatically updated to reflect the committed changes.