Page MenuHomePhabricator
Differential D861

Replace nHashType with SigHashType in rawtransaction.cpp
ClosedPublic
Actions

Authored by jasonbcox on Jan 2 2018, 00:05.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING711f194b7ae7: Replace nHashType with SigHashType in rawtransaction.cpp
rABC711f194b7ae7: Replace nHashType with SigHashType in rawtransaction.cpp
Summary

Continue work replacing nHashType with SigHashType (see T61). Depends on D860.

Test Plan

Existing tests pass, which do hit this branch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rawtrans
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1483
Build 1483: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 2 2018, 00:05
Owners added a reviewer: Restricted Owners Package.Jan 2 2018, 00:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 2 2018, 00:05
deadalnix requested changes to this revision.Jan 2 2018, 00:56
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1032 ↗(On Diff #2278)
sigHashType.getBaseSigHashType() != BaseSigHashType::SINGLE
This revision now requires changes to proceed.Jan 2 2018, 00:56
jasonbcox updated this revision to Diff 2291.Jan 3 2018, 03:40

Fixed if statement negation

Harbormaster completed remote builds in B1483: Diff 2291.Jan 3 2018, 03:40
deadalnix accepted this revision.Jan 3 2018, 12:59
This revision is now accepted and ready to land.Jan 3 2018, 12:59
Closed by commit rABC711f194b7ae7: Replace nHashType with SigHashType in rawtransaction.cpp (authored by jasonbcox). · Explain WhyJan 4 2018, 00:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
rpc/
16 lines

Diff 2291

View Options

src/rpc/rawtransaction.cpp

Loading...