Page MenuHomePhabricator

gui: Remove unused interfaces::Node references
ClosedPublic

Authored by Fabien on Dec 10 2020, 23:28.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCdb2846573f32: gui: Remove unused interfaces::Node references
Summary
Remove Node references no longer needed after previous commit

Partial backport (2/4) of bitcoin-core/gui PR35:
https://github.com/bitcoin-core/gui/pull/35/commits/91aced7c7e6e75c1f5896b7e3843015177f32748

Depends on D8653.

Test Plan
ninja all check-all

Event Timeline

Tail of the build log:

[372/431] Running utility command for check-bitcoin-merkleblock_tests
[373/431] Running utility command for check-bitcoin-bip32_tests
[374/431] bitcoin: testing torcontrol_tests
[375/431] Running utility command for check-bitcoin-sighashtype_tests
[376/431] Running utility command for check-bitcoin-sync_tests
[377/431] bitcoin: testing wallet_crypto_tests
[378/431] Running utility command for check-bitcoin-torcontrol_tests
[379/431] Running utility command for check-bitcoin-wallet_crypto_tests
[380/431] bitcoin: testing timedata_tests
[381/431] bitcoin: testing streams_tests
[382/431] bitcoin: testing uint256_tests
[383/431] Running utility command for check-bitcoin-timedata_tests
[384/431] bitcoin: testing undo_tests
[385/431] bitcoin: testing util_threadnames_tests
[386/431] Running utility command for check-bitcoin-streams_tests
[387/431] Running utility command for check-bitcoin-uint256_tests
[388/431] Running utility command for check-bitcoin-undo_tests
[389/431] Running utility command for check-bitcoin-util_threadnames_tests
[390/431] bitcoin: testing compilerbug_tests
[391/431] bitcoin: testing validation_chainstatemanager_tests
[392/431] Running utility command for check-bitcoin-compilerbug_tests
[393/431] bitcoin: testing checkpoints_tests
[394/431] Running utility command for check-bitcoin-validation_chainstatemanager_tests
[395/431] bitcoin: testing cuckoocache_tests
[396/431] bitcoin: testing validationinterface_tests
[397/431] Running utility command for check-bitcoin-checkpoints_tests
[398/431] Running utility command for check-bitcoin-cuckoocache_tests
[399/431] Running utility command for check-bitcoin-validationinterface_tests
[400/431] bitcoin: testing txvalidationcache_tests
[401/431] Running utility command for check-bitcoin-txvalidationcache_tests
[402/431] bitcoin: testing getarg_tests
[403/431] Running utility command for check-bitcoin-getarg_tests
[404/431] bitcoin: testing radix_tests
[405/431] Running utility command for check-bitcoin-radix_tests
[406/431] bitcoin: testing ref_tests
[407/431] Running utility command for check-bitcoin-ref_tests
[408/431] bitcoin: testing blockcheck_tests
[409/431] Running utility command for check-bitcoin-blockcheck_tests
[410/431] bitcoin: testing crypto_tests
[411/431] Running utility command for check-bitcoin-crypto_tests
[412/431] bitcoin: testing monolith_opcodes_tests
[413/431] Running utility command for check-bitcoin-monolith_opcodes_tests
[414/431] bitcoin: testing validation_tests
[415/431] Running utility command for check-bitcoin-validation_tests
[416/431] bitcoin: testing script_tests
[417/431] Running utility command for check-bitcoin-script_tests
[418/431] bitcoin: testing skiplist_tests
[419/431] Running utility command for check-bitcoin-skiplist_tests
[420/431] bitcoin: testing validation_block_tests
[421/431] Running utility command for check-bitcoin-validation_block_tests
[422/431] bitcoin: testing util_tests
[423/431] Running utility command for check-bitcoin-util_tests
[424/431] bitcoin: testing op_reversebytes_tests
[425/431] Running utility command for check-bitcoin-op_reversebytes_tests
[426/431] bitcoin: testing transaction_tests
[427/431] Running utility command for check-bitcoin-transaction_tests
[428/431] bitcoin: testing coins_tests
[429/431] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
This revision is now accepted and ready to land.Dec 11 2020, 08:35
This revision was landed with ongoing or failed builds.Dec 14 2020, 08:02
This revision was automatically updated to reflect the committed changes.