Paths

Table of Contentst

Differential D8699

gui: Remove WalletView and BitcoinGUI circular dependency
ClosedPublic
Actions

Authored by PiRK on Dec 18 2020, 14:38.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC94bf18e8bf1c: gui: Remove WalletView and BitcoinGUI circular dependency

Summary

Essentially moves the code in WalletView::setBitcoinGUI to the only caller.

Remove the circular dependency "qt/bitcoingui -> qt/walletview -> qt/bitcoingui"

This is a backport of Core PR17937 [2/2]
https://github.com/bitcoin/bitcoin/pull/17937/commits/cb8a86d9f952401eaad68b2e3818ce50f7befd91

Depends on D8698

Test Plan

ninja && src/qt/bitcoin-qt
Test some of the connections

Run test/lint/lint-circular-dependencies.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17937

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14447
Build 28861: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28860: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 18 2020, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2020, 14:38

PiRK requested review of this revision.Dec 18 2020, 14:38

teamcity edited the summary of this revision. (Show Details)Dec 18 2020, 14:38

PiRK edited the summary of this revision. (Show Details)Dec 18 2020, 14:39

PiRK added a parent revision: D8698: gui: Add transactionClicked and coinsSent signals to WalletView.

Harbormaster completed remote builds in B14447: Diff 26429.Dec 18 2020, 14:50

majcosta accepted this revision.Dec 18 2020, 19:13

This revision is now accepted and ready to land.Dec 18 2020, 19:13

Closed by commit rABC94bf18e8bf1c: gui: Remove WalletView and BitcoinGUI circular dependency (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyDec 19 2020, 11:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC94bf18e8bf1c: gui: Remove WalletView and BitcoinGUI circular dependency.

Revision Contents
Changeset List

Path

Size

src/

qt/

walletframe.cpp

15 lines

walletview.h

2 lines

walletview.cpp

32 lines

test/

lint/

lint-circular-dependencies.sh

1 line

Diff 26429

View Options

src/qt/walletframe.cpp

View Options

src/qt/walletview.h

View Options

src/qt/walletview.cpp

View Options

test/lint/lint-circular-dependencies.sh

gui: Remove WalletView and BitcoinGUI circular dependencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26429

src/qt/walletframe.cpp

src/qt/walletview.h

src/qt/walletview.cpp

test/lint/lint-circular-dependencies.sh

gui: Remove WalletView and BitcoinGUI circular dependency
ClosedPublic
Actions

Revision Contents
Changeset List