Page MenuHomePhabricator
Differential D8804

[backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err
ClosedPublic
Actions

Authored by majcosta on Jan 6 2021, 10:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC685164613eda: [backport#13655] bitcoinconsensus: invalid flags error should be set to…
Summary

417b6c1d2990ffc78c029442e027797d724a101f bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes (Thomas Kerin)

Pull request description:

A check was added to the bitcoinconsensus verify_script codepath to ensure that callers only used _exposed_ interpreter flags. I think this error should be written to `bitcoinconsensus_err* err` and not returned by verify_script?

I modified the check so it indicates the error using *err like the others, and added tests covering the error codes.

Backport of Core PR13655

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 6 2021, 10:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2021, 10:46
majcosta requested review of this revision.Jan 6 2021, 10:46
teamcity edited the summary of this revision. (Show Details)Jan 6 2021, 10:46
majcosta edited the summary of this revision. (Show Details)Jan 6 2021, 10:52
Harbormaster completed remote builds in B14593: Diff 26672.Jan 6 2021, 11:30
majcosta updated this revision to Diff 26686.Jan 6 2021, 14:11
majcosta edited the summary of this revision. (Show Details)

readded test case using bitcoinconsensus_SCRIPT_ENABLE_SIGHASH_FORKID instead

majcosta edited the summary of this revision. (Show Details)Jan 6 2021, 14:12
Harbormaster completed remote builds in B14598: Diff 26686.Jan 6 2021, 14:24
Fabien accepted this revision.Jan 6 2021, 14:56
This revision is now accepted and ready to land.Jan 6 2021, 14:56
Closed by commit rABC685164613eda: [backport#13655] bitcoinconsensus: invalid flags error should be set to… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJan 6 2021, 20:51
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC685164613eda: [backport#13655] bitcoinconsensus: invalid flags error should be set to….

Revision Contents
Changeset List

PathSize
src/
script/
2 lines
test/
147 lines

Diff 26693

View Options

src/script/bitcoinconsensus.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...