Replace std::to_string with locale-independent alternative
ClosedPublic
Actions

Authored by PiRK on Jan 12 2021, 10:07.

Details

Reviewers

Fabien
majcosta

Group Reviewers

Restricted Project

Commits

rABC47a5b8aad9e2: Replace std::to_string with locale-independent alternative

Summary

std::to_string relies on the current locale for formatting purposes

This is a backport of Core PR18134 and PR17851

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18134

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14718
Build 29395: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-debug · build-clang
Build 29394: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 12 2021, 10:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2021, 10:07

PiRK requested review of this revision.Jan 12 2021, 10:07

teamcity edited the summary of this revision. (Show Details)Jan 12 2021, 10:07

Harbormaster completed remote builds in B14713: Diff 26869.Jan 12 2021, 10:21

Please also backport https://github.com/bitcoin/bitcoin/pull/17851. You can easily squash them, and that will prevent from introducing the issue again.

This revision now requires changes to proceed.Jan 12 2021, 10:38

majcosta requested changes to this revision.Jan 12 2021, 11:04

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/test/util/setup_common.cpp
31 ↗	(On Diff #26869)	this probably shouldn't be in both the header and the cpp file

add std::to_string to LocaleDependenceLinter.php (this is a backport of Core PR17851), replace std::to_string in a few more source files detected by the linter and remove #include <util/string.h> from setup_common.cpp when it is already included in the header file.

PiRK edited the summary of this revision. (Show Details)Jan 12 2021, 14:53

Harbormaster completed remote builds in B14718: Diff 26878.Jan 12 2021, 15:16

majcosta accepted this revision.Jan 12 2021, 15:18

Fabien accepted this revision.Jan 12 2021, 15:48

This revision is now accepted and ready to land.Jan 12 2021, 15:48

Closed by commit rABC47a5b8aad9e2: Replace std::to_string with locale-independent alternative (authored by Ben Woosley <ben.woosley@gmail.com>, committed by PiRK). · Explain WhyJan 12 2021, 16:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC47a5b8aad9e2: Replace std::to_string with locale-independent alternative.