Paths

Table of Contentst

Differential D8924

doc: default minconf for getbalance should be 0
ClosedPublic
Actions

Authored by PiRK on Jan 15 2021, 08:33.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC28e2e62864b0: doc: default minconf for getbalance should be 0

Summary

Default minconf for getbalance is 0 but example in doc was showing as 1.

at least 6 blocks confirmed now updated to be at least 6 confirmations to be more consistent with the terminology used elsewhere in the codebase and documentations.

This is a backport of Core PR18502

Test Plan

Check the new help message:

src/bitcoin-cli help getbalance

Check that the balance includes unconfirmed transactions by sending some fund to an external wallet and running immediately src/bitcoin-cli getbalance

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 15 2021, 08:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2021, 08:33

PiRK requested review of this revision.Jan 15 2021, 08:33

teamcity edited the summary of this revision. (Show Details)Jan 15 2021, 08:33

Harbormaster completed remote builds in B14789: Diff 26988.Jan 15 2021, 08:47

Fabien accepted this revision.Jan 15 2021, 10:16

This revision is now accepted and ready to land.Jan 15 2021, 10:16

Closed by commit rABC28e2e62864b0: doc: default minconf for getbalance should be 0 (authored by U-Zyn Chua <chua@uzyn.com>, committed by PiRK). · Explain WhyJan 15 2021, 10:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC28e2e62864b0: doc: default minconf for getbalance should be 0.

Revision Contents
Changeset List

Path

Size

src/

wallet/

4 lines

Diff 26997

src/wallet/rpcwallet.cpp

Loading...