script: Disallow silent bool -> CScript conversion
ClosedPublic
Actions

Authored by PiRK on Jan 17 2021, 09:30.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC4f308eaa812b: script: Disallow silent bool -> CScript conversion

Summary

Makes nonsensical stuff like ScriptToAsmStr(false,false); a compile failure

This is a backport of Core PR18621

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18621

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14809
Build 29572: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-without-wallet · build-clang · build-debug
Build 29571: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 17 2021, 09:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2021, 09:30

PiRK requested review of this revision.Jan 17 2021, 09:30

teamcity edited the summary of this revision. (Show Details)Jan 17 2021, 09:30

Harbormaster completed remote builds in B14809: Diff 27023.Jan 17 2021, 09:43

majcosta accepted this revision.Jan 17 2021, 10:33

This revision is now accepted and ready to land.Jan 17 2021, 10:33

Closed by commit rABC4f308eaa812b: script: Disallow silent bool -> CScript conversion (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 18 2021, 09:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4f308eaa812b: script: Disallow silent bool -> CScript conversion.

Revision Contents
Changeset List

Path

Size

src/

script/

script.h

2 lines

Diff 27023

View Options

script: Disallow silent bool -> CScript conversionClosedPublicActions