[wallet] Update the rebroadcast frequency to be ~1/day.
ClosedPublic
Actions

Authored by PiRK on Jan 21 2021, 11:37.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC232939a30114: [wallet] Update the rebroadcast frequency to be ~1/day.

Summary

Since the mempool unbroadcast mechanism handles the reattempts for initial
broadcast, the wallet rebroadcast attempts can be much less frequent
(previously ~1/30 min)

This is a backport of Core PR18038 [4/7]
https://github.com/bitcoin/bitcoin/pull/18038/commits/dc1da48dc5e5526215561311c184a8cbc345ecdc
Depends on D9008

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 21 2021, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2021, 11:37

PiRK requested review of this revision.Jan 21 2021, 11:37

teamcity edited the summary of this revision. (Show Details)Jan 21 2021, 11:38

PiRK added a child revision: D9010: [refactor/test] Extract P2PTxInvStore into test framework.Jan 21 2021, 11:38

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_bind.py ======

------- Stdout: -------
2021-01-21T11:55:07.020000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210121_115505/rpc_bind_492
2021-01-21T11:55:07.021000Z TestFramework (INFO): Check for linux
2021-01-21T11:55:07.045000Z TestFramework (INFO): Check for ipv6
2021-01-21T11:55:07.045000Z TestFramework (INFO): Check for non-loopback interface
2021-01-21T11:55:07.045000Z TestFramework (INFO): Bind test for []
2021-01-21T11:55:07.520000Z TestFramework (INFO): Bind test for []
2021-01-21T11:55:07.991000Z TestFramework (INFO): Bind test for ['[::1]']
2021-01-21T11:55:08.417000Z TestFramework (INFO): Bind test for ['127.0.0.1', '[::1]']
2021-01-21T11:55:08.895000Z TestFramework (INFO): Using interface 172.17.0.2 for testing
2021-01-21T11:55:08.895000Z TestFramework (INFO): Bind test for ['172.17.0.2']
2021-01-21T11:55:09.174000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/rpc_bind.py", line 136, in run_test
    self._run_nonloopback_tests()
  File "/work/test/functional/rpc_bind.py", line 171, in _run_nonloopback_tests
    [(self.non_loopback_ip, self.defaultport)])
  File "/work/test/functional/rpc_bind.py", line 72, in run_bind_test
    assert_equal(set(get_bind_addrs(pid)), set(expected))
  File "/work/test/functional/test_framework/netutil.py", line 87, in get_bind_addrs
    inodes = get_socket_inodes(pid)
  File "/work/test/functional/test_framework/netutil.py", line 37, in get_socket_inodes
    target = os.readlink(os.path.join(base, item))
FileNotFoundError: [Errno 2] No such file or directory: '/proc/4784/fd/16'
2021-01-21T11:55:09.225000Z TestFramework (INFO): Stopping nodes
2021-01-21T11:55:09.377000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210121_115505/rpc_bind_492
2021-01-21T11:55:09.377000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210121_115505/rpc_bind_492/test_framework.log
2021-01-21T11:55:09.377000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210121_115505/rpc_bind_492' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py

Harbormaster completed remote builds in B14902: Diff 27171.Jan 21 2021, 11:59

rebase

Harbormaster completed remote builds in B14907: Diff 27182.Jan 21 2021, 13:40

majcosta accepted this revision.Jan 21 2021, 13:53

This revision is now accepted and ready to land.Jan 21 2021, 13:53

Closed by commit rABC232939a30114: [wallet] Update the rebroadcast frequency to be ~1/day. (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJan 21 2021, 17:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC232939a30114: [wallet] Update the rebroadcast frequency to be ~1/day..