Page MenuHomePhabricator

Disable CWalletTx copy constructor
ClosedPublic

Authored by PiRK on Jan 27 2021, 10:16.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC19dfc4927677: Disable CWalletTx copy constructor
Summary

Disable copying of CWalletTx objects to prevent bugs where instances get copied
in and out of the mapWallet map and fields are updated in the wrong copy.

This is a backport of Core PR9381 [4/5]
https://github.com/bitcoin/bitcoin/pull/9381/commits/d002f9d15d938e78360ad906f2d74a249c7e923e
Depends on D9076

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Jan 27 2021, 10:16
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/test/psbt_wallet_tests.cpp
46

remove pls

This revision is now accepted and ready to land.Jan 27 2021, 15:06

remove spurious blank line

This revision was automatically updated to reflect the committed changes.