Page MenuHomePhabricator
Differential D908

Refactor ZapWalletTxes to avoid layer violations
ClosedPublic
Actions

Authored by deadalnix on Jan 6 2018, 23:39.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9a341912807f: Refactor ZapWalletTxes to avoid layer violations
rABC9a341912807f: Refactor ZapWalletTxes to avoid layer violations
Summary

Backport of core's PR9143

Depends on D907

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
zapwalletrefac
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/wallet/wallet.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 1536
Build 1536: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 6 2018, 23:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2018, 23:39
Harbormaster completed remote builds in B1536: Diff 2385.Jan 6 2018, 23:39
deadalnix updated this revision to Diff 2386.Jan 6 2018, 23:44

rebase

Harbormaster completed remote builds in B1537: Diff 2386.Jan 6 2018, 23:44
deadalnix added a child revision: D910: [Wallet] refactor CWallet/CWalletDB/CDB.Jan 7 2018, 00:09
deadalnix updated this revision to Diff 2409.Jan 7 2018, 20:28

rebase, ping.

schancel retitled this revision from Refactor ZapWalletTxes to avoid layer vialotions to Refactor ZapWalletTxes to avoid layer violations.Jan 8 2018, 02:21
schancel accepted this revision.Jan 8 2018, 05:46
This revision is now accepted and ready to land.Jan 8 2018, 05:46
Closed by commit rABC9a341912807f: Refactor ZapWalletTxes to avoid layer violations (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by deadalnix). · Explain WhyJan 8 2018, 11:02
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
12 lines
6 lines
17 lines

Diff 2385

View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...