Replace nHashType with SigHashType in script/sign
ClosedPublic
Actions

Authored by jasonbcox on Jan 6 2018, 23:49.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING2b9cc7954bcd: Replace nHashType with SigHashType in script/sign
rABC2b9cc7954bcd: Replace nHashType with SigHashType in script/sign

Summary

Continue refactors for T61. D885 depends on this diff.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

signhash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1538
Build 1538: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 6 2018, 23:49

Owners added a reviewer: Restricted Owners Package.Jan 6 2018, 23:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2018, 23:49

Fixed negation statement

Harbormaster completed remote builds in B1539: Diff 2388.Jan 6 2018, 23:51

deadalnix accepted this revision.Jan 7 2018, 00:02

deadalnix added inline comments.

src/test/script_tests.cpp
1361 ↗	(On Diff #2388)	Can you put the comment on the previous line ?

This revision is now accepted and ready to land.Jan 7 2018, 00:02

Closed by commit rABC2b9cc7954bcd: Replace nHashType with SigHashType in script/sign (authored by jasonbcox). · Explain WhyJan 7 2018, 00:48

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

24 lines

rpc/

rawtransaction.cpp

3 lines

script/

sign.h

13 lines

sign.cpp

18 lines

test/

DoS_tests.cpp

4 lines

multisig_tests.cpp

2 lines

script_P2SH_tests.cpp

16 lines

script_tests.cpp

11 lines

transaction_tests.cpp

2 lines

txvalidationcache_tests.cpp

4 lines

wallet/

wallet.cpp

2 lines

Diff 2387

View Options

src/bitcoin-tx.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/sign.h

View Options

src/script/sign.cpp

View Options

src/test/DoS_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

Replace nHashType with SigHashType in script/signClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2387

src/bitcoin-tx.cpp

src/rpc/rawtransaction.cpp

src/script/sign.h

src/script/sign.cpp

src/test/DoS_tests.cpp

src/test/multisig_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/wallet.cpp

Replace nHashType with SigHashType in script/sign
ClosedPublic
Actions

Revision Contents
Changeset List