Differential D9126

scripted-diff: TxoutType C++11 scoped enum class
ClosedPublic
Actions

Authored by Fabien on Feb 1 2021, 16:53.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC97c446e3bf66: scripted-diff: TxoutType C++11 scoped enum class

Summary

Non-scoped enums can accidentally and silently decay into an integral
type. Also, the symbol names of the keys are exported to the surrounding
(usually global) namespace.

Fix both issues by switching to an enum class TxoutType in a (mostly)
scripted-diff.

Backport of core PR19114.

Depends on D9124.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19114

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15070
Build 30090: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-clang · build-clang-tidy · build-debug
Build 30089: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 1 2021, 16:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2021, 16:53

Fabien requested review of this revision.Feb 1 2021, 16:53

teamcity edited the summary of this revision. (Show Details)Feb 1 2021, 16:53

Harbormaster completed remote builds in B15070: Diff 27458.Feb 1 2021, 17:08

PiRK added a subscriber: PiRK.Feb 1 2021, 17:12

PiRK added inline comments.

src/script/standard.h
106	This line should probably be indented, if doygen works the way I think it works.

majcosta accepted this revision.Feb 1 2021, 18:50

This revision is now accepted and ready to land.Feb 1 2021, 18:50

Fabien added inline comments.Feb 2 2021, 07:34

src/script/standard.h
106	There was no issue with the previous version which had the same layout, so I think it's fine: https://www.bitcoinabc.org/doc/dev/standard_8h.html#a1706cd790b4c6a3c2bb687b7826309a9