Page MenuHomePhabricator
Differential D9129

net: Use mockable time for ping/pong, add tests
ClosedPublic
Actions

Authored by Fabien on Feb 2 2021, 13:15.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0f688cf6874d: net: Use mockable time for ping/pong, add tests
Summary
Switch CNode::m_ping_start and CNetMessage::m_time to mockable time, so
that tests can be added.

Mockable time is also type-safe, since it uses std::chrono

Backport of core PR18638.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
25 lines
28 lines
2 lines
29 lines
test/
fuzz/
3 lines
2 lines
util/
6 lines
test/
functional/
15 lines
7 lines
134 lines

Diff 27481

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/fuzz/p2p_transport_deserializer.cpp

Loading...
View Options

src/test/fuzz/process_message.cpp

Loading...
View Options

src/util/time.h

Loading...
View Options

test/functional/feature_bip68_sequence.py

Loading...
View Options

test/functional/feature_maxuploadtarget.py

Loading...
View Options

test/functional/p2p_ping.py

Loading...