Differential D9147

scripted-diff: rename base_blob::data to m_data
ClosedPublic
Actions

Authored by Fabien on Feb 3 2021, 16:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC676c36c107ae: scripted-diff: rename base_blob::data to m_data

Summary

This is in preparation for exposing a ::data member function.

-BEGIN VERIFY SCRIPT-
sed -i "s/\([^.]\|other.\)data/\1m_data/g" src/uint256.h src/uint256.cpp
-END VERIFY SCRIPT-

Partial backport of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/131a2f0337f5c396739a47b60bb856ed84ec8937

The comparison fonction differs due to D1527.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19326_p1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15097
Build 30144: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 30143: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 3 2021, 16:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 16:35

Fabien requested review of this revision.Feb 3 2021, 16:35

teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 16:35

Fabien added a child revision: D9148: Make uint256 Span-convertible by adding ::data().Feb 3 2021, 16:39

Harbormaster completed remote builds in B15097: Diff 27511.Feb 3 2021, 17:04

majcosta accepted this revision.Feb 3 2021, 17:12

This revision is now accepted and ready to land.Feb 3 2021, 17:12

Closed by commit rABC676c36c107ae: scripted-diff: rename base_blob::data to m_data (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyFeb 4 2021, 08:50

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC676c36c107ae: scripted-diff: rename base_blob::data to m_data.

Revision Contents
Changeset List

Path

Size

src/

30 lines

13 lines

Diff 27511

src/uint256.h

Loading...

src/uint256.cpp

Loading...