Differential D9153

Make CHash256/CHash160 output to Span
ClosedPublic
Actions

Authored by Fabien on Feb 3 2021, 16:59.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC241746830113: Make CHash256/CHash160 output to Span

Summary

Partial backport (7/8) of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/02c4cc5c5ddf61f98ee366a4bea8abc26de492bd

Depends on D9152.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 3 2021, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 16:59

Fabien requested review of this revision.Feb 3 2021, 16:59

teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 16:59

Fabien added a child revision: D9154: Make Hash[160] consume range-like objects.Feb 3 2021, 17:03

Harbormaster completed remote builds in B15104: Diff 27518.Feb 3 2021, 17:57

majcosta accepted this revision.Feb 3 2021, 20:21

This revision is now accepted and ready to land.Feb 3 2021, 20:21

Closed by commit rABC241746830113: Make CHash256/CHash160 output to Span (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyFeb 4 2021, 08:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC241746830113: Make CHash256/CHash160 output to Span.

Revision Contents
Changeset List

Path

Size

src/

4 lines

18 lines

2 lines

2 lines

script/

interpreter.cpp

4 lines

test/

crypto_tests.cpp

2 lines

fuzz/

crypto.cpp

4 lines

key_tests.cpp

2 lines

merkle_tests.cpp

6 lines

Diff 27536

View Options

src/blockfilter.cpp

View Options

src/hash.h

View Options

src/key.cpp

View Options

src/net.cpp

View Options

src/script/interpreter.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/fuzz/crypto.cpp

View Options

src/test/key_tests.cpp

View Options

Make CHash256/CHash160 output to SpanClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27536

src/blockfilter.cpp

src/hash.h

src/key.cpp

src/net.cpp

src/script/interpreter.cpp

src/test/crypto_tests.cpp

src/test/fuzz/crypto.cpp

src/test/key_tests.cpp

src/test/merkle_tests.cpp

Make CHash256/CHash160 output to Span
ClosedPublic
Actions

Revision Contents
Changeset List