Differential D9148

Make uint256 Span-convertible by adding ::data()
ClosedPublic
Actions

Authored by Fabien on Feb 3 2021, 16:39.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC6d6b676c0a4a: Make uint256 Span-convertible by adding ::data()

Summary

Partial backport (2/8) of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/567825049fb0e47e698dcaad9caa65693a6b42d3

Depends on D9147.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19326_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15098
Build 30146: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 30145: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 3 2021, 16:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 16:39

Fabien requested review of this revision.Feb 3 2021, 16:39

teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 16:39

Rebase

Fabien added a child revision: D9149: Add MakeUCharSpan, to help constructing Span<[const] unsigned char>.Feb 3 2021, 16:43

Harbormaster completed remote builds in B15098: Diff 27512.Feb 3 2021, 17:10

Harbormaster completed remote builds in B15099: Diff 27513.Feb 3 2021, 17:17

majcosta accepted this revision.Feb 3 2021, 19:13

This revision is now accepted and ready to land.Feb 3 2021, 19:13

Closed by commit rABC6d6b676c0a4a: Make uint256 Span-convertible by adding ::data() (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyFeb 4 2021, 08:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6d6b676c0a4a: Make uint256 Span-convertible by adding ::data().

Revision Contents
Changeset List

Path

Size

src/

uint256.h

3 lines

Diff 27512

View Options

Make uint256 Span-convertible by adding ::data()ClosedPublicActions