Differential D9151

Make CHash256 and CHash160 consume Spans
ClosedPublic
Actions

Authored by Fabien on Feb 3 2021, 16:51.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf494ab366979: Make CHash256 and CHash160 consume Spans

Summary

Partial backport (5/8) of core PR19326:
https://github.com/bitcoin/bitcoin/pull/19326/commits/e549bf8a9afae42fcda805e216a1cde62df195a6

The segwit related parts have been skipped.

Depends on D9150.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19326_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15102
Build 30154: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 30153: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 3 2021, 16:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 16:51

Fabien requested review of this revision.Feb 3 2021, 16:51

teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 16:51

Fabien added a child revision: D9152: Make MurmurHash3 consume Spans.Feb 3 2021, 16:54

Harbormaster completed remote builds in B15102: Diff 27516.Feb 3 2021, 17:40

majcosta accepted this revision.Feb 3 2021, 20:16

This revision is now accepted and ready to land.Feb 3 2021, 20:16

Closed by commit rABCf494ab366979: Make CHash256 and CHash160 consume Spans (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyFeb 4 2021, 08:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf494ab366979: Make CHash256 and CHash160 consume Spans.

Revision Contents
Changeset List

Path

Size

src/

bench/

2 lines

7 lines

26 lines

5 lines

2 lines

script/

interpreter.cpp

8 lines

test/

crypto_tests.cpp

2 lines

fuzz/

4 lines

5 lines

15 lines

2 lines

4 lines

Diff 27516

View Options

src/bench/chacha_poly_aead.cpp

View Options

src/blockfilter.cpp

View Options

src/hash.h

View Options

src/key.cpp

View Options

src/net.cpp

View Options

src/script/interpreter.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/fuzz/crypto.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/merkle_tests.cpp

View Options

src/test/settings_tests.cpp

View Options

Make CHash256 and CHash160 consume SpansClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27516

src/bench/chacha_poly_aead.cpp

src/blockfilter.cpp

src/hash.h

src/key.cpp

src/net.cpp

src/script/interpreter.cpp

src/test/crypto_tests.cpp

src/test/fuzz/crypto.cpp

src/test/key_tests.cpp

src/test/merkle_tests.cpp

src/test/settings_tests.cpp

src/test/util_tests.cpp

Make CHash256 and CHash160 consume Spans
ClosedPublic
Actions

Revision Contents
Changeset List