Differential D9200

net: advertise support for ADDRv2 via new message
ClosedPublic
Actions

Authored by Fabien on Feb 10 2021, 11:17.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC15f4d6097a4a: net: advertise support for ADDRv2 via new message

Summary

Introduce a new message `sendaddrv2` to signal support for ADDRv2.
Send the new message immediately after sending the `VERACK` message.

Add support for receiving and parsing ADDRv2 messages.

Send ADDRv2 messages (instead of ADDR) to a peer if he has
advertised support for it.

Partial backport (3/4) of core PR19954:
https://github.com/bitcoin/bitcoin/pull/19954/commits/353a3fdaad055eea42a0baf7326bdd591f541170

Depends on D9199.

Some functional tests required a debug log message update since we where
using a slightly different form from core. The new code is in sync with
core's message to make later backports easier.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 10 2021, 11:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2021, 11:17

Fabien requested review of this revision.Feb 10 2021, 11:17

teamcity edited the summary of this revision. (Show Details)Feb 10 2021, 11:17

Fabien added a child revision: D9201: tor: make a TORv3 hidden service instead of TORv2.Feb 10 2021, 11:23

Harbormaster completed remote builds in B15165: Diff 27630.Feb 10 2021, 11:31

majcosta requested changes to this revision.Feb 10 2021, 18:31

majcosta added a subscriber: majcosta.

majcosta added inline comments.

test/functional/p2p_invalid_messages.py
300–317 ↗	(On Diff #27630)	something like this, ditto for cases above

This revision now requires changes to proceed.Feb 10 2021, 18:31

Improve comments layout

Harbormaster completed remote builds in B15177: Diff 27650.Feb 10 2021, 20:57

majcosta accepted this revision.Feb 10 2021, 21:36

This revision is now accepted and ready to land.Feb 10 2021, 21:36

Closed by commit rABC15f4d6097a4a: net: advertise support for ADDRv2 via new message (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain WhyFeb 11 2021, 08:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC15f4d6097a4a: net: advertise support for ADDRv2 via new message.

Revision Contents
Changeset List

Path

Size

src/

14 lines

net_processing.cpp

52 lines

7 lines

30 lines

13 lines

24 lines

test/

17 lines

test/

functional/

p2p_addr_relay.py

2 lines

	p2p_addrv2_relay.py
	p2p_addr_relay.py

46 lines

p2p_invalid_messages.py

120 lines

test_framework/

104 lines

14 lines

Diff 27658

src/net.h

Loading...

src/net_processing.cpp

Loading...

src/netaddress.h

Loading...

src/netaddress.cpp

Loading...

src/protocol.h

Loading...

src/protocol.cpp

Loading...

src/test/net_tests.cpp

Loading...

test/functional/p2p_addr_relay.py

Loading...

test/functional/p2p_addrv2_relay.py

Loading...

test/functional/p2p_invalid_messages.py

Loading...

test/functional/test_framework/messages.py

Loading...

test/functional/test_framework/mininode.py

Loading...