Page MenuHomePhabricator

BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals.
ClosedPublic

Authored by PiRK on Mon, Feb 22, 14:46.

Details

Summary
Test Plan

ninja && src/qt/bitcoin-qt
Send a transaction, wait for a few block and check that the tx status is correctly updated in the interface.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Mon, Feb 22, 14:47

Tail of the build log:

[377/433] Running utility command for check-bitcoin-sighashtype_tests
[378/433] Running utility command for check-bitcoin-addrman_tests
[379/433] bitcoin: testing sync_tests
[380/433] bitcoin: testing torcontrol_tests
[381/433] Running utility command for check-bitcoin-sync_tests
[382/433] Running utility command for check-bitcoin-torcontrol_tests
[383/433] bitcoin: testing settings_tests
[384/433] Running utility command for check-bitcoin-settings_tests
[385/433] bitcoin: testing scriptpubkeyman_tests
[386/433] Running utility command for check-bitcoin-scriptpubkeyman_tests
[387/433] bitcoin: testing txvalidationcache_tests
[388/433] bitcoin: testing uint256_tests
[389/433] bitcoin: testing serialize_tests
[390/433] bitcoin: testing radix_tests
[391/433] bitcoin: testing blockcheck_tests
[392/433] Running utility command for check-bitcoin-txvalidationcache_tests
[393/433] Running utility command for check-bitcoin-uint256_tests
[394/433] bitcoin: testing schnorr_tests
[395/433] Running utility command for check-bitcoin-serialize_tests
[396/433] Running utility command for check-bitcoin-radix_tests
[397/433] Running utility command for check-bitcoin-blockcheck_tests
[398/433] Running utility command for check-bitcoin-schnorr_tests
[399/433] bitcoin: testing undo_tests
[400/433] bitcoin: testing validation_chainstatemanager_tests
[401/433] Running utility command for check-bitcoin-undo_tests
[402/433] bitcoin: testing ismine_tests
[403/433] Running utility command for check-bitcoin-validation_chainstatemanager_tests
[404/433] bitcoin: testing walletdb_tests
[405/433] bitcoin: testing cuckoocache_tests
[406/433] bitcoin: testing script_tests
[407/433] Running utility command for check-bitcoin-ismine_tests
[408/433] Running utility command for check-bitcoin-cuckoocache_tests
[409/433] Running utility command for check-bitcoin-walletdb_tests
[410/433] Running utility command for check-bitcoin-script_tests
[411/433] bitcoin: testing ref_tests
[412/433] bitcoin: testing cashaddr_tests
[413/433] bitcoin: testing validation_tests
[414/433] bitcoin: testing wallet_tests
[415/433] Running utility command for check-bitcoin-ref_tests
[416/433] Running utility command for check-bitcoin-cashaddr_tests
[417/433] Running utility command for check-bitcoin-validation_tests
[418/433] Running utility command for check-bitcoin-wallet_tests
[419/433] bitcoin: testing crypto_tests
[420/433] Running utility command for check-bitcoin-crypto_tests
[421/433] bitcoin: testing skiplist_tests
[422/433] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,message:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Segmentation fault (core dumped)
[423/433] Running utility command for check-bitcoin-skiplist_tests
[424/433] bitcoin: testing util_tests
[425/433] Running utility command for check-bitcoin-util_tests
[426/433] bitcoin: testing op_reversebytes_tests
[427/433] Running utility command for check-bitcoin-op_reversebytes_tests
[428/433] bitcoin: testing transaction_tests
[429/433] Running utility command for check-bitcoin-transaction_tests
[430/433] bitcoin: testing coins_tests
[431/433] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Mon, Feb 22, 18:41

remove line accidentaly added while fixing a conflict