Page MenuHomePhabricator
Differential D9257

qt: Fix regression in TransactionTableModel
ClosedPublic
Actions

Authored by PiRK on Feb 22 2021, 15:18.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1efc1fd37759: qt: Fix regression in TransactionTableModel
Summary

Since PR17993 a crash is possible on exit.

Co-authored-by: Russell Yanofsky <russ@yanofsky.org>

This is a backport of core-gui#8

Depends on D9254

Test Plan

start bitcoin-qt
wait until sync
on main window: Menu -> File -> Quit

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 22 2021, 15:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2021, 15:18
PiRK requested review of this revision.Feb 22 2021, 15:18
teamcity edited the summary of this revision. (Show Details)Feb 22 2021, 15:19
PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 15:19
PiRK added a parent revision: D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Harbormaster completed remote builds in B15249: Diff 27767.Feb 22 2021, 15:31
majcosta requested changes to this revision.Feb 22 2021, 18:53
majcosta added a subscriber: majcosta.

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

This revision now requires changes to proceed.Feb 22 2021, 18:53
PiRK added a comment.EditedFeb 22 2021, 20:56

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 20:57
majcosta added a comment.Feb 22 2021, 20:59
In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

on it

PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 21:00
PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 21:02
PiRK edited the summary of this revision. (Show Details)Feb 23 2021, 07:16
PiRK updated this revision to Diff 27780.EditedFeb 23 2021, 09:24

rebase

Harbormaster completed remote builds in B15258: Diff 27780.Feb 23 2021, 09:38
majcosta accepted this revision.Feb 23 2021, 09:40
This revision is now accepted and ready to land.Feb 23 2021, 09:40
Closed by commit rABC1efc1fd37759: qt: Fix regression in TransactionTableModel (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 23 2021, 12:54
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1efc1fd37759: qt: Fix regression in TransactionTableModel.

Revision Contents
Changeset List

Diff 27787

View Options

src/qt/transactionrecord.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...