Page MenuHomePhabricator

qt: Fix regression in TransactionTableModel
ClosedPublic

Authored by PiRK on Mon, Feb 22, 15:18.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1efc1fd37759: qt: Fix regression in TransactionTableModel
Summary

Since PR17993 a crash is possible on exit.

Co-authored-by: Russell Yanofsky <russ@yanofsky.org>

This is a backport of core-gui#8

Depends on D9254

Test Plan

start bitcoin-qt
wait until sync
on main window: Menu -> File -> Quit

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Mon, Feb 22, 15:18
majcosta requested changes to this revision.Mon, Feb 22, 18:53
majcosta added a subscriber: majcosta.

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

This revision now requires changes to proceed.Mon, Feb 22, 18:53

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

on it

This revision is now accepted and ready to land.Tue, Feb 23, 09:40