qt: Fix regression in TransactionTableModel
ClosedPublic
Actions

Authored by PiRK on Feb 22 2021, 15:18.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1efc1fd37759: qt: Fix regression in TransactionTableModel

Summary

Since PR17993 a crash is possible on exit.

Co-authored-by: Russell Yanofsky <russ@yanofsky.org>

This is a backport of core-gui#8

Depends on D9254

Test Plan

start bitcoin-qt
wait until sync
on main window: Menu -> File -> Quit

Diff Detail

Repository

rABC Bitcoin ABC

Branch

prgui8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15258
Build 30453: Build Diff	build-without-wallet · build-debug · lint-circular-dependencies · build-diff · build-clang · build-clang-tidy
Build 30452: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 22 2021, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2021, 15:18

PiRK requested review of this revision.Feb 22 2021, 15:18

teamcity edited the summary of this revision. (Show Details)Feb 22 2021, 15:19

PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 15:19

PiRK added a parent revision: D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..

Harbormaster completed remote builds in B15249: Diff 27767.Feb 22 2021, 15:31

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

This revision now requires changes to proceed.Feb 22 2021, 18:53

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

PiRK edited the summary of this revision. (Show Details)Feb 22 2021, 20:57