Page MenuHomePhabricator

[buildbot] make bot link to backports of core-gui repo
ClosedPublic

Authored by majcosta on Mon, Feb 22, 22:39.

Details

Reviewers
Fabien
PiRK
Group Reviewers
Restricted Project
Commits
rABC5c69fab896b6: [buildbot] make bot link to backports of core-gui repo
Summary

the idea is to have a markdown convention that will link to the two repos we already backport from and include the bitcoin-core/gui repo

after this diff I establish the following convention:

summary text in the format LOWERCASE_SUPPORTED_REPO_PREFIX#PR_NUMBER will be replaced with a link to the appropriate PR if LOWERCASE_SUPPORTED_REPO_PREFIX is in the relevant dictionary in server.py

examples:

core#17234 should replace to core#17234

core-gui#9 to core-gui#9

and secp256k1#894 to secp256k1#894

Test Plan
pytest

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Failed tests logs:

====== test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_happyPath ======
 
200 != 500

self = <test.test_endpoint_backportcheck.EndpointBackportcheckTestCase testMethod=test_backportCheck_happyPath>
first = 500, second = 200, msg = None

    def _patched_equals(self, first, second, msg=None):
        try:
>           old(self, first, second, msg)

/usr/local/lib/python3.7/dist-packages/teamcity/diff_tools.py:32: 

====== test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_hasNoPRs ======
 
200 != 500

self = <test.test_endpoint_backportcheck.EndpointBackportcheckTestCase testMethod=test_backportCheck_hasNoPRs>
first = 500, second = 200, msg = None

    def _patched_equals(self, first, second, msg=None):
        try:
>           old(self, first, second, msg)

/usr/local/lib/python3.7/dist-packages/teamcity/diff_tools.py:32: 

====== test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_hasPRs ======
 
200 != 500

self = <test.test_endpoint_backportcheck.EndpointBackportcheckTestCase testMethod=test_backportCheck_hasPRs>
first = 500, second = 200, msg = None

    def _patched_equals(self, first, second, msg=None):
        try:
>           old(self, first, second, msg)

/usr/local/lib/python3.7/dist-packages/teamcity/diff_tools.py:32:

Each failure log is accessible here:
test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_happyPath
test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_hasNoPRs
test_endpoint_backportcheck.EndpointBackportcheckTestCase.test_backportCheck_hasPRs

majcosta edited the summary of this revision. (Show Details)

making the tests happy

added test cases and removed test cases that no longer apply (the number of digits in PRs are no longer in the code)

This revision is now accepted and ready to land.Tue, Feb 23, 07:13