Page MenuHomePhabricator

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions
ClosedPublic

Authored by PiRK on Wed, Apr 28, 15:49.

Details

Summary

This simplifies control flow and also helps get rid of the ::vpwallets
variable, because EnsureWalletIsAvailable doesn't have access to the request
context.

This is a backport of core#19100

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Apr 28, 15:49
deadalnix requested changes to this revision.Wed, Apr 28, 15:55
deadalnix added a subscriber: deadalnix.

Can you use the common denomination for backports, so that this can be grepped for? I just realized that I greened several of these, I shouldn't have. This is making keeping track of things in git pretty much impossible.

This revision now requires changes to proceed.Wed, Apr 28, 15:55
PiRK requested review of this revision.Wed, Apr 28, 18:57

We changed the convention recently, because now we have multiple repos to backport from (core, gui and secp256k1) : D9258

This revision is now accepted and ready to land.Thu, Apr 29, 11:49