refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions
ClosedPublic
Actions

Authored by PiRK on Apr 28 2021, 15:49.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC51c94b782d08: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable…

Summary

This simplifies control flow and also helps get rid of the ::vpwallets
variable, because EnsureWalletIsAvailable doesn't have access to the request
context.

This is a backport of core#19100

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19100

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15593
Build 31102: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-without-wallet · build-clang
Build 31101: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 28 2021, 15:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2021, 15:49

PiRK requested review of this revision.Apr 28 2021, 15:49

teamcity edited the summary of this revision. (Show Details)Apr 28 2021, 15:49

Can you use the common denomination for backports, so that this can be grepped for? I just realized that I greened several of these, I shouldn't have. This is making keeping track of things in git pretty much impossible.

This revision now requires changes to proceed.Apr 28 2021, 15:55

Harbormaster completed remote builds in B15593: Diff 28294.Apr 28 2021, 16:03

We changed the convention recently, because now we have multiple repos to backport from (core, gui and secp256k1) : D9258

PiRK added a child revision: D9455: wallet: Make RPC help compile-time static.Apr 28 2021, 20:33

deadalnix accepted this revision.Apr 29 2021, 11:49

This revision is now accepted and ready to land.Apr 29 2021, 11:49

Closed by commit rABC51c94b782d08: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable… (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyApr 29 2021, 11:54

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC51c94b782d08: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable….