Page MenuHomePhabricator

Refactor RPC: Access wallet through GetWalletForJSONRPCRequest
ClosedPublic

Authored by deadalnix on Jan 9 2018, 23:36.

Details

Summary

Partially backport core's PR8775, namely:

RPC/Wallet: Pass CWallet as pointer to helper functions
RPC: Do all wallet access through new GetWalletForJSONRPCRequest

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletrpcrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1564
Build 1564: arc lint + arc unit

Event Timeline

Include various nits made later on to these files.

The rest looks good to me.

src/rpc/server.h
231

Remove first "should" in this comment.

src/wallet/rpcdump.cpp
1207

Looks like this newline should be removed

jasonbcox requested changes to this revision.Jan 10 2018, 19:37
This revision now requires changes to proceed.Jan 10 2018, 19:37

Fix nonsensical sentence in comments.

This revision is now accepted and ready to land.Jan 10 2018, 21:09
This revision was automatically updated to reflect the committed changes.