Page MenuHomePhabricator

net: Extract download permission from noban
ClosedPublic

Authored by Fabien on Mar 16 2021, 21:22.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC56f61132d708: net: Extract download permission from noban
Summary
It should be possible to grant nodes in a local network (e.g. home,
university, enterprise, ...) permission to download blocks even after
the maxuploadtarget is hit.

Currently this is only possible by setting the noban permission, which
has some adverse effects, especially if the peers can't be fully
trusted.

Fix this by extracting a download permission from noban.

Backport of core#19191.

Depends on D9324 and D9325.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Mar 16 2021, 21:22
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/init.cpp
798 ↗(On Diff #27945)

pls bring the formatting changes over or it's going to be a totally unrelated merge conflict down the road

This revision is now accepted and ready to land.Mar 17 2021, 14:20

Add missing formatting changes + improve layout