Differential D9402

[SECP256K1] Add safegcd based modular inverse modules
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:23.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC24b590d38544: [SECP256K1] Add safegcd based modular inverse modules

Summary

Comes with full documentation and tests.

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/8e415acba25830da9c23a4dd5531ebfc6b65aae7
https://github.com/bitcoin-core/secp256k1/pull/831/commits/d8a92fcc4c65cf189ec7bd5298dad8479347c442
https://github.com/bitcoin-core/secp256k1/pull/831/commits/151aac00d31ba5e94800376f6fda4193071168af

Depends on D9401.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR831_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15497
Build 30914: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-diff · build-debug · build-clang-tidy · build-clang
Build 30913: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2021, 18:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:23

Fabien requested review of this revision.Apr 13 2021, 18:23

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:24

Fabien added a child revision: D9403: [SECP256K1] Improve bounds checks in modinv modules.Apr 13 2021, 18:24

Harbormaster completed remote builds in B15497: Diff 28155.Apr 13 2021, 18:51

majcosta accepted this revision.Apr 13 2021, 21:11

This revision is now accepted and ready to land.Apr 13 2021, 21:11

Closed by commit rABC24b590d38544: [SECP256K1] Add safegcd based modular inverse modules (authored by Peter Dettman <peter.dettman@gmail.com>, committed by Fabien). · Explain WhyApr 14 2021, 06:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC24b590d38544: [SECP256K1] Add safegcd based modular inverse modules.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

4 lines

doc/

safegcd_implementation.md

750 lines

src/

42 lines

modinv32_impl.h

397 lines

46 lines

modinv64_impl.h

393 lines

444 lines

Diff 28155

src/secp256k1/Makefile.am

Loading...

src/secp256k1/doc/safegcd_implementation.md

Loading...

src/secp256k1/src/modinv32.h

Loading...

src/secp256k1/src/modinv32_impl.h

Loading...

src/secp256k1/src/modinv64.h

Loading...

src/secp256k1/src/modinv64_impl.h

Loading...

src/secp256k1/src/tests.c

Loading...