Differential D9405

[SECP256K1] Make field/scalar code use the new modinv modules for inverses
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:27.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1080f989e5b7: [SECP256K1] Make field/scalar code use the new modinv modules for inverses

Summary

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/1e0e885c8ac814c3621d9e43e66d60f25e324e8e

Depends on D9404.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR831_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15500
Build 30920: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-diff · build-debug · build-clang · build-clang-tidy
Build 30919: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2021, 18:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:27

Fabien requested review of this revision.Apr 13 2021, 18:27

Fabien added a child revision: D9406: [SECP256K1] Improve field/scalar inverse tests.

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:28

Harbormaster completed remote builds in B15500: Diff 28158.Apr 13 2021, 19:16

majcosta accepted this revision.Apr 13 2021, 23:09

This revision is now accepted and ready to land.Apr 13 2021, 23:09

Closed by commit rABC1080f989e5b7: [SECP256K1] Make field/scalar code use the new modinv modules for inverses (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyApr 14 2021, 06:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1080f989e5b7: [SECP256K1] Make field/scalar code use the new modinv modules for inverses.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

2 lines

src/

field_10x26_impl.h

186 lines

field_5x52_impl.h

172 lines

scalar_4x64_impl.h

217 lines

scalar_8x32_impl.h

239 lines

Diff 28158

src/secp256k1/README.md

Loading...

src/secp256k1/src/field_10x26_impl.h

Loading...

src/secp256k1/src/field_5x52_impl.h

Loading...

src/secp256k1/src/scalar_4x64_impl.h

Loading...

src/secp256k1/src/scalar_8x32_impl.h

Loading...