Differential D9407

[SECP256K1] Remove unused scalar_sqr
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:29.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1faa18ac9231: [SECP256K1] Remove unused scalar_sqr

Summary

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/5437e7bdfbffddf69fdf7b4af7e997c78f5dafbf

Depends on D9406.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR831_p7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15502
Build 30924: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-diff · build-clang-tidy · build-debug · build-clang
Build 30923: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2021, 18:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:29

Fabien requested review of this revision.Apr 13 2021, 18:29

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:30

Fabien added a child revision: D9408: [SECP256K1] Remove num/gmp support.Apr 13 2021, 18:31

Harbormaster completed remote builds in B15502: Diff 28160.Apr 13 2021, 19:26

majcosta accepted this revision.Apr 13 2021, 23:29

This revision is now accepted and ready to land.Apr 13 2021, 23:29

Closed by commit rABC1faa18ac9231: [SECP256K1] Remove unused scalar_sqr (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyApr 14 2021, 06:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1faa18ac9231: [SECP256K1] Remove unused scalar_sqr.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

bench_internal.c

10 lines

3 lines

scalar_4x64_impl.h

166 lines

scalar_8x32_impl.h

89 lines

scalar_low_impl.h

4 lines

16 lines

Diff 28160

src/secp256k1/src/bench_internal.c

Loading...

src/secp256k1/src/scalar.h

Loading...

src/secp256k1/src/scalar_4x64_impl.h

Loading...

src/secp256k1/src/scalar_8x32_impl.h

Loading...

src/secp256k1/src/scalar_low_impl.h

Loading...

src/secp256k1/src/tests.c

Loading...