[avalanche] Move the session key to the PeerData structure
AbandonedPublic
Actions

Authored by Fabien on Apr 15 2021, 12:46.

Details

Reviewers

PiRK
deadalnix

Group Reviewers

Restricted Project

Summary

The PeerData structure contains the data needed to participate to the
avalanche network, this is where the session key belong. This will allow
for initializing the PeerData from the ArgsManager and make it
independent from the Processor.

Depends on D9418.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_session_key_peer_data

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15516
Build 30952: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 30951: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2021, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2021, 12:46

Fabien requested review of this revision.Apr 15 2021, 12:46

Fabien added a child revision: D9420: [avalanche] Initialize PeerData from ArgsManager.Apr 15 2021, 12:49

Harbormaster completed remote builds in B15516: Diff 28190.Apr 15 2021, 12:59

PiRK accepted this revision.Apr 16 2021, 17:05

This revision is now accepted and ready to land.Apr 16 2021, 17:05

This will allow for initializing the PeerData from the ArgsManager and make it independent from the Processor.

You just created that problem. For the love of god, please guys. Read the god damn code you write. Don't write more code to fix the problem you just created, you don't create the problem in the first place.

You started with something that MUST be consistent by desing. Now you have something that is consistent due to numerous runtime checks with a more complex API. This is not progress.

This revision now requires changes to proceed.Apr 19 2021, 23:40

Fabien abandoned this revision.Apr 22 2021, 12:47