[avalanche] Initialize PeerData from ArgsManager
AbandonedPublic
Actions

Authored by Fabien on Apr 15 2021, 12:49.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

This actually makes the PeerData initialization independent from the
processor initialization. Next step is to move the initial proof
verification to the PeerData constructor as well.

Depends on D9419.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_init_peer_data

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15517
Build 30954: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 30953: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2021, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2021, 12:49

Fabien requested review of this revision.Apr 15 2021, 12:49

Fabien added a child revision: D9421: [avalanche] Move the initial proof verification to PeerData constructor.Apr 15 2021, 12:53

Harbormaster completed remote builds in B15517: Diff 28191.Apr 15 2021, 13:04

This kinda have the right idea, but the execution is a problem. For as long as you do these in the various constructors, you must have objects at the end, and therefore you end up constructing possibly invalid objects, which is just bad design.

@PiRK started creating a factory method to construct the avalanche::Processor, why is this approach suddenly better?

Passing down the arg manager is a yes, but the execution isn't right.

This revision now requires changes to proceed.Apr 19 2021, 23:29

Fabien abandoned this revision.Apr 22 2021, 12:47