An unsollicited avalanche message is not special in any way, compared to any other form of spam or unknown messages. So just ignore them in the same way.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- proofmaster_avahello
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15788 Build 31476: Build Diff build-without-wallet · build-debug · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang Build 31475: arc lint + arc unit
Event Timeline
| src/net_processing.cpp | ||
|---|---|---|
| 2627 | If you just ignore undesired message then there is no reason to ban at all ? | |
Comment Actions
We probably shouldn't ignore unsolicited messages en general.
But in this specific case, no it is not the same. The proof is in the pudding, the message is "Unknown command \"%s\" from peer=%d\n", which is clearly not true for avalanche related messages.
| src/net_processing.cpp | ||
|---|---|---|
| 2628 ↗ | (On Diff #28613) | All this achieve is skipping the code handling the fact that the message was ignored. This doesn't seem to be very useful. |
| 2631 ↗ | (On Diff #28613) | This code didn't really made a lot of sense to begin with. The ban is applied inconsistently. Is the message suddenly expected if g_avalanche is unset? In addition, why isn't this grouped with the rest of the avalanche processing in there? Why isn't IsAvalancheMessageType static? |