Differential D9589

[avalanche] Remove unused getProof() method in the avalanche processor
ClosedPublic
Actions

Authored by Fabien on May 26 2021, 19:24.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa79173fa8ba4: [avalanche] Remove unused getProof() method in the avalanche processor

Summary

This is no longer used and is confusing as it only returns the "local"
proof if there is some.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_getproof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15819
Build 31538: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 31537: arc lint + arc unit

Event Timeline

Fabien created this revision.May 26 2021, 19:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2021, 19:24

Fabien requested review of this revision.May 26 2021, 19:24

Harbormaster completed remote builds in B15819: Diff 28623.May 26 2021, 19:38

deadalnix accepted this revision.May 26 2021, 21:04

This revision is now accepted and ready to land.May 26 2021, 21:04

Closed by commit rABCa79173fa8ba4: [avalanche] Remove unused getProof() method in the avalanche processor (authored by Fabien). · Explain WhyMay 27 2021, 07:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa79173fa8ba4: [avalanche] Remove unused getProof() method in the avalanche processor.

PiRK mentioned this in D9478: [avalanche] make avalanche peer discovery in a simple case.Jun 2 2021, 15:29

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

8 lines

processor.cpp

7 lines

Diff 28623

View Options

src/avalanche/processor.h