Page MenuHomePhabricator

[avalanche] Add an avaproof network permission for bypassing the inv tracking limit
ClosedPublic

Authored by Fabien on May 31 2021, 13:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC38e511b2b8ea: [avalanche] Add an avaproof network permission for bypassing the inv tracking…
Summary

This flag is unset by default and bypasses the proof inventory tracking
limit so an unlimited number of proofs can be downloaded from a peer.
The flag bit is set at the latest position to prevent from futur
conflicts.

Part of T1611.

Test Plan
ninja all check-all
ninja fuzz-net_permissions

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 31 2021, 13:45
deadalnix requested changes to this revision.May 31 2021, 15:23
deadalnix added a subscriber: deadalnix.

I don't get what is the intended behavior here. avaproof doesn't seems to be a permission that make sense.

src/net_permissions.h
37 ↗(On Diff #28679)

I don't think the comment describing this makes any sense. What does this do?

This revision now requires changes to proceed.May 31 2021, 15:23

Improve doc and pick a more descriptive name

Mengerian added a task: Restricted Maniphest Task.Jun 3 2021, 18:23
This revision is now accepted and ready to land.Jun 4 2021, 10:02