Page MenuHomePhabricator
Differential D9608

[avalanche] Add an avaproof network permission for bypassing the inv tracking limit
ClosedPublic
Actions

Authored by Fabien on May 31 2021, 13:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC38e511b2b8ea: [avalanche] Add an avaproof network permission for bypassing the inv tracking…
Summary

This flag is unset by default and bypasses the proof inventory tracking
limit so an unlimited number of proofs can be downloaded from a peer.
The flag bit is set at the latest position to prevent from futur
conflicts.

Part of T1611.

Test Plan
ninja all check-all
ninja fuzz-net_permissions

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 31 2021, 13:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2021, 13:45
Fabien requested review of this revision.May 31 2021, 13:45
Fabien edited the summary of this revision. (Show Details)May 31 2021, 13:55
Harbormaster completed remote builds in B15856: Diff 28679.May 31 2021, 13:59
deadalnix requested changes to this revision.May 31 2021, 15:23
deadalnix added a subscriber: deadalnix.

I don't get what is the intended behavior here. avaproof doesn't seems to be a permission that make sense.

src/net_permissions.h
37 ↗(On Diff #28679)

I don't think the comment describing this makes any sense. What does this do?

This revision now requires changes to proceed.May 31 2021, 15:23
Fabien updated this revision to Diff 28720.Jun 2 2021, 11:39

Improve doc and pick a more descriptive name

Fabien mentioned this in D9582: [avalanche] Answer proof invs with getdata proof requests.Jun 2 2021, 19:40
Fabien added a child revision: D9582: [avalanche] Answer proof invs with getdata proof requests.Jun 2 2021, 19:40
Harbormaster completed remote builds in B15883: Diff 28720.Jun 3 2021, 16:19
Mengerian added a task: Restricted Maniphest Task.Jun 3 2021, 18:23
deadalnix accepted this revision.Jun 4 2021, 10:02
This revision is now accepted and ready to land.Jun 4 2021, 10:02
Closed by commit rABC38e511b2b8ea: [avalanche] Add an avaproof network permission for bypassing the inv tracking… (authored by Fabien). · Explain WhyJun 4 2021, 11:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC38e511b2b8ea: [avalanche] Add an avaproof network permission for bypassing the inv tracking….

Revision Contents
Changeset List

PathSize
src/
5 lines
7 lines
test/
fuzz/
1 line
11 lines
test/
functional/
9 lines

Diff 28751

View Options

src/net_permissions.h

Loading...
View Options

src/net_permissions.cpp

Loading...
View Options

src/test/fuzz/net_permissions.cpp

Loading...
View Options

src/test/netbase_tests.cpp

Loading...
View Options

test/functional/p2p_permissions.py

Loading...