Page MenuHomePhabricator

Make SetMiscWarning() accept bilingual_str argument
ClosedPublic

Authored by PiRK on Mon, May 31, 14:12.

Details

Summary
Test Plan

ninja all check-all

grep -r SetMiscWarning src/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, May 31, 14:12
This revision is now accepted and ready to land.Mon, May 31, 19:35
majcosta requested changes to this revision.Mon, May 31, 19:37
majcosta added a subscriber: majcosta.

looks like we're missing something in validation.cpp

src/warnings.cpp
44 ↗(On Diff #28681)

should this be removed? it is removed in the original PR

This revision now requires changes to proceed.Mon, May 31, 19:37
PiRK edited the test plan for this revision. (Show Details)

remove an unused string in warnings.cpp

Regarding the difference in validation.cpp, I wasn't able to figure out why they have more occurences of SetMiscWarning than we do. I grepped for it, and for the missing AppendWarning function. On git blame it seems like old code that we no longer have, not new code that we haven't backported yet.

This revision is now accepted and ready to land.Mon, May 31, 20:03