Page MenuHomePhabricator

rpc: remove deprecated getaddressinfo fields
ClosedPublic

Authored by PiRK on Jun 2 2021, 14:21.

Details

Reviewers
majcosta
Mengerian
Group Reviewers
Restricted Project
Commits
rABC5f4b8a11f74d: rpc: remove deprecated getaddressinfo fields
Summary

rpc: remove deprecated getaddressinfo label field

rpc: remove deprecated getaddressinfo labels: purpose

rpc: getaddressinfo RPCResult fixup

doc: release note for rpc getaddressinfo removals

This is a backport of core#19200

Depends on D9609

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jun 2 2021, 14:21

green, just as long as you rebase on top of D9609 after it lands :)

This revision is now accepted and ready to land.Jun 2 2021, 17:48

remove the empty release-notes-19200.md

Mengerian requested changes to this revision.Jun 2 2021, 17:53
Mengerian added a subscriber: Mengerian.

There's something strange going on with the release notes.

For one thing, the old release notes should be moved over in a separate Diff. Looks like they were just deleted, and an empty file was created (doc/release-notes-19200.md). This filename is wrong for our repo, the old release notes should have been copied over to doc/release-notes-0.23.4.md in a separate previous Diff.

Also, for some reason the Description doesn't have a clickable link to the orginal Core PR https://github.com/bitcoin/bitcoin/pull/19200

This revision now requires changes to proceed.Jun 2 2021, 17:53

rebase after version bump in D9609. This fixes the release-notes.md mess.

This revision is now accepted and ready to land.Jun 3 2021, 14:09
This revision was automatically updated to reflect the committed changes.