Differential D9625

[avalanche] Add a facility to check if a peer is preferred for DL
ClosedPublic
Actions

Authored by Fabien on Jun 3 2021, 10:19.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC9f241cc79d56: [avalanche] Add a facility to check if a peer is preferred for DL

Summary

This wraps up the access to the state's fPreferredDownload flag to
prevent code duplication.

There is no change in behavior.

Depends on D9582.

Part of T1611.

Test Plan

ninja all check-all
./test/functional/test_runner.py p2p_inv_download

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ispreferreddownloadpeer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15896
Build 31692: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 31691: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 3 2021, 10:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2021, 10:19

Fabien requested review of this revision.Jun 3 2021, 10:19

Harbormaster completed remote builds in B15896: Diff 28737.Jun 3 2021, 10:40

Fabien added a child revision: D9627: [avalanche] Download the proof from our peers that send avahello.Jun 3 2021, 12:28

PiRK accepted this revision.Jun 3 2021, 13:21

This revision is now accepted and ready to land.Jun 3 2021, 13:21

Mengerian added a task: Restricted Maniphest Task.Jun 3 2021, 18:23

Closed by commit rABC9f241cc79d56: [avalanche] Add a facility to check if a peer is preferred for DL (authored by Fabien). · Explain WhyJun 4 2021, 19:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9f241cc79d56: [avalanche] Add a facility to check if a peer is preferred for DL.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

20 lines

Diff 28737

View Options

[avalanche] Add a facility to check if a peer is preferred for DLClosedPublicActions