appInit
ClosedPublic
Actions

Authored by PiRK on Jul 5 2021, 07:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcc3538aeb2f1: [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit

Summary

PR description:

During the GUI startup, there is currently an accumulation of cs_main locks due to setting initial chain state values at multiple locations (in the GUI main thread).

This PR tries to cache the initial chain state (tip height, tip time, best header, etc.) short after loading the blockindex.

The cached values are then used instead of fetching them again (and thus locking cs_main) during setting the client model.

This should fix the initial GUI blocking often experienced during or short after the splashscreen.

https://github.com/bitcoin/bitcoin/pull/19011/commits/b354a1480abbd71fb7fb82c39c81ea0644bbfce4

Add BlockAndHeaderTipInfo to the node interface/appInit

https://github.com/bitcoin/bitcoin/pull/19011/commits/d42cb790687788c78aa2f0c1988238ab52050782

Optionally populate BlockAndHeaderTipInfo during AppInitMain

This is a backport of core#19011 [2&3/4]
The commits needed squashing because the first one alone breaks the build.

Depends on D9734

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16104
Build 32082: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32081: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 5 2021, 07:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2021, 07:55

PiRK requested review of this revision.Jul 5 2021, 07:55

teamcity edited the summary of this revision. (Show Details)Jul 5 2021, 07:55

PiRK edited the summary of this revision. (Show Details)Jul 5 2021, 07:56

PiRK added a child revision: D9736: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup.Jul 5 2021, 07:58

PiRK retitled this revision from Add BlockAndHeaderTipInfo to the node interface/appInit to [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit.Jul 5 2021, 07:58

Harbormaster completed remote builds in B16104: Diff 29059.Jul 5 2021, 08:15

Fabien accepted this revision.Jul 5 2021, 15:01

This revision is now accepted and ready to land.Jul 5 2021, 15:01

Closed by commit rABCcc3538aeb2f1: [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyJul 6 2021, 07:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcc3538aeb2f1: [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit.