[core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections
ClosedPublic
Actions

Authored by PiRK on Jul 12 2021, 16:02.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC45b19beb72a9: [core#19724 7/9][refactor] Simplify connection type logic in…

Summary

Consolidate the logic to determine connection type into one conditional to
clarify how they are chosen.

This is a backport of core#19724 [7/9]
https://github.com/bitcoin/bitcoin/pull/19724/commits/4829b6fcc6489b445f80689af6c2a1a919f176b1

Depends on D9775

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 12 2021, 16:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2021, 16:02

PiRK requested review of this revision.Jul 12 2021, 16:02

teamcity edited the summary of this revision. (Show Details)Jul 12 2021, 16:02

PiRK added a child revision: D9777: [core#19724 8/9][doc] Describe connection types in more depth..Jul 12 2021, 16:04

Harbormaster completed remote builds in B16163: Diff 29150.Jul 12 2021, 16:36

majcosta accepted this revision.Jul 12 2021, 21:21

This revision is now accepted and ready to land.Jul 12 2021, 21:21

Closed by commit rABC45b19beb72a9: [core#19724 7/9][refactor] Simplify connection type logic in… (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJul 13 2021, 14:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC45b19beb72a9: [core#19724 7/9][refactor] Simplify connection type logic in….

Revision Contents
Changeset List

Path

Size

src/

net.cpp

64 lines

Diff 29166

View Options

[core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnectionsClosedPublicActions