Page MenuHomePhabricator
Differential D982

[tests] Functional tests call self.start_node(s) and self.stop_node(s)
ClosedPublic
Actions

Authored by deadalnix on Jan 19 2018, 01:47.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGb4c7004421a5: [tests] Functional tests call self.start_node(s) and self.stop_node(s)
rABCb4c7004421a5: [tests] Functional tests call self.start_node(s) and self.stop_node(s)
Summary

This commit changes the individual test scripts to call the
start_node(s) and stop_node(s) methods in BitcoinTestFramework.

This is the first part of the backport of core's PR10359

Depends on D976, D972, D978, D981 and D983

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
callframeworkstartstop
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1660
Build 1660: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 19 2018, 01:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2018, 01:47
Harbormaster completed remote builds in B1660: Diff 2582.Jan 19 2018, 01:48
deadalnix added a parent revision: D978: Remove func test code duplication.Jan 19 2018, 01:48
deadalnix removed a parent revision: D977: sync_with_ping should assert that ping hasn't timed out.
deadalnix edited the summary of this revision. (Show Details)
deadalnix planned changes to this revision.Jan 19 2018, 02:16

This breaks pruning.py

deadalnix updated this revision to Diff 2588.Jan 19 2018, 03:46

Rebase on top of D983 in order to fix pruning.py

Harbormaster completed remote builds in B1665: Diff 2588.Jan 19 2018, 03:46
deadalnix edited the summary of this revision. (Show Details)Jan 19 2018, 03:46
deadalnix added a parent revision: D983: Improve DisconnectTip performance.
schancel accepted this revision.Jan 19 2018, 05:53
This revision is now accepted and ready to land.Jan 19 2018, 05:53
Closed by commit rABCb4c7004421a5: [tests] Functional tests call self.start_node(s) and self.stop_node(s) (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyJan 20 2018, 12:30
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2582

View Options

test/functional/abandonconflict.py

Loading...
View Options

test/functional/assumevalid.py

Loading...
View Options

test/functional/bip9-softforks.py

Loading...
View Options

test/functional/blockchain.py

Loading...
View Options

test/functional/disconnect_ban.py

Loading...
View Options

test/functional/forknotify.py

Loading...
View Options

test/functional/fundrawtransaction.py

Loading...
View Options

test/functional/import-rescan.py

Loading...
View Options

test/functional/importmulti.py

Loading...
View Options

test/functional/keypool.py

Loading...
View Options

test/functional/listtransactions.py

Loading...
View Options

test/functional/maxuploadtarget.py

Loading...
View Options

test/functional/mempool_persist.py

Loading...
View Options

test/functional/net.py

Loading...
View Options

test/functional/p2p-versionbits-warning.py

Loading...
View Options

test/functional/proxy_test.py

Loading...
View Options

test/functional/pruning.py

Loading...
View Options

test/functional/receivedby.py

Loading...
View Options

test/functional/reindex.py

Loading...
View Options

test/functional/rpcbind_test.py

Loading...
View Options

test/functional/smartfees.py

Loading...
View Options

test/functional/wallet-accounts.py

Loading...
View Options

test/functional/wallet-dump.py

Loading...
View Options

test/functional/wallet-hd.py

Loading...
View Options

test/functional/wallet.py

Loading...
View Options

test/functional/walletbackup.py

Loading...
View Options

test/functional/zapwallettxes.py

Loading...
View Options

test/functional/zmq_test.py

Loading...