Page MenuHomePhabricator
Differential D983

Improve DisconnectTip performance
ClosedPublic
Actions

Authored by deadalnix on Jan 19 2018, 03:41.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf18009a4d63e: Improve DisconnectTip performance
rABCf18009a4d63e: Improve DisconnectTip performance
Summary

This backport core's PR9208

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 19 2018, 03:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2018, 03:41
Harbormaster completed remote builds in B1664: Diff 2587.Jan 19 2018, 03:41
deadalnix mentioned this in D982: [tests] Functional tests call self.start_node(s) and self.stop_node(s).Jan 19 2018, 03:46
deadalnix added a child revision: D982: [tests] Functional tests call self.start_node(s) and self.stop_node(s).Jan 19 2018, 03:46
jasonbcox accepted this revision.Jan 19 2018, 04:19
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.h
80 ↗(On Diff #2587)

Thought for later: should we scale this value by max blocksize? It seems this value is too low if block sizes are high (and hence transaction counts are also high).

This revision is now accepted and ready to land.Jan 19 2018, 04:19
deadalnix added inline comments.Jan 19 2018, 15:42
src/validation.h
80 ↗(On Diff #2587)

Yes it probably should.

Closed by commit rABCf18009a4d63e: Improve DisconnectTip performance (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyJan 19 2018, 15:49
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
5 lines
94 lines
2 lines
2 lines
150 lines
test/
functional/
41 lines

Diff 2593

View Options

src/core_memusage.h

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/pruning.py

Loading...