Page MenuHomePhabricator

test: Set -logthreadnames in unit tests
AbandonedPublic

Authored by PiRK on Jul 22 2021, 15:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

init: Setup scheduler in tests and init in exactly the same way

test: Set -logthreadnames in unit tests

PR description:
Generally the unit tests are single threaded, with the exception of the script check threads, the schedule, and optionally indexer threads.

Like the functional tests, the thread name can serve additional debug information, so set -logthreadnames in unit tests.

This is a backport of core#19028

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Jul 22 2021, 15:48
Fabien requested changes to this revision.Jul 23 2021, 07:06
Fabien added a subscriber: Fabien.

The test plan is not testing the feature

This revision now requires changes to proceed.Jul 23 2021, 07:06
PiRK planned changes to this revision.Jul 23 2021, 09:36

testing depends on core#16975

Depends on a diff that got reverted (D9971, D9990). I can't figure out how to fix it and imo it is not worth spending too much effort on this.